consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add and apply Capybara/RSpec/HaveSelector rule

Browse Source 
This rule was added in rubocop-capybara 2.19.0. We were following it
about 85% of the time.

Now we won't have to check both have_css and have_selector when
searching the code.
This commit is contained in:
Javi Martín
2023-10-03 18:35:51 +02:00
parent 83f3cbc143
commit 0cec581ec0
53 changed files with 206 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
spec/components/valuation/budgets/row_component_spec.rb
View File

@@ -14,7 +14,7 @@ describe Valuation::Budgets::RowComponent do
render_inline Valuation::Budgets::RowComponent.new(budget: budget)
expect(page).to have_selector ".investments-count", text: "1"
expect(page).to have_css ".investments-count", text: "1"
end
it "counts investments assigned to the valuator group" do
@@ -24,7 +24,7 @@ describe Valuation::Budgets::RowComponent do
render_inline Valuation::Budgets::RowComponent.new(budget: budget)
expect(page).to have_selector ".investments-count", text: "1"
expect(page).to have_css ".investments-count", text: "1"
end
it "does not count investments with valuation finished" do
@@ -36,7 +36,7 @@ describe Valuation::Budgets::RowComponent do
render_inline Valuation::Budgets::RowComponent.new(budget: budget)
expect(page).to have_selector ".investments-count", text: "0"
expect(page).to have_css ".investments-count", text: "0"
end
it "displays zero when the budget hasn't reached the valuating phase" do
@@ -45,7 +45,7 @@ describe Valuation::Budgets::RowComponent do
render_inline Valuation::Budgets::RowComponent.new(budget: budget)
expect(page).to have_selector ".investments-count", text: "0"
expect(page).to have_css ".investments-count", text: "0"
end
it "displays zero when the valuating phase is over" do
@@ -54,7 +54,7 @@ describe Valuation::Budgets::RowComponent do
render_inline Valuation::Budgets::RowComponent.new(budget: budget)
expect(page).to have_selector ".investments-count", text: "0"
expect(page).to have_css ".investments-count", text: "0"
end
end