consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add and apply Capybara/RSpec/HaveSelector rule

Browse Source 
This rule was added in rubocop-capybara 2.19.0. We were following it
about 85% of the time.

Now we won't have to check both have_css and have_selector when
searching the code.
This commit is contained in:
Javi Martín
2023-10-03 18:35:51 +02:00
parent 83f3cbc143
commit 0cec581ec0
53 changed files with 206 additions and 203 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
spec/components/shared/advanced_search_component_spec.rb
View File

@@ -28,8 +28,8 @@ describe Shared::AdvancedSearchComponent do
render_inline component
expect(page).not_to have_selector "#advanced_search_goal", visible: :all
expect(page).not_to have_selector "#advanced_search_target", visible: :all
expect(page).not_to have_css "#advanced_search_goal", visible: :all
expect(page).not_to have_css "#advanced_search_target", visible: :all
end
it "does not render when the SDG process feature is disabled" do
@@ -37,15 +37,15 @@ describe Shared::AdvancedSearchComponent do
render_inline component
expect(page).not_to have_selector "#advanced_search_goal", visible: :all
expect(page).not_to have_selector "#advanced_search_target", visible: :all
expect(page).not_to have_css "#advanced_search_goal", visible: :all
expect(page).not_to have_css "#advanced_search_target", visible: :all
end
it "renders when both features are enabled" do
render_inline component
expect(page).to have_selector "#advanced_search_goal", visible: :all
expect(page).to have_selector "#advanced_search_target", visible: :all
expect(page).to have_css "#advanced_search_goal", visible: :all
expect(page).to have_css "#advanced_search_target", visible: :all
end
end
end