Add and apply Capybara/RSpec/HaveSelector rule

This rule was added in rubocop-capybara 2.19.0. We were following it
about 85% of the time.

Now we won't have to check both have_css and have_selector when
searching the code.
This commit is contained in:
Javi Martín
2023-10-03 18:35:51 +02:00
parent 83f3cbc143
commit 0cec581ec0
53 changed files with 206 additions and 203 deletions

View File

@@ -70,8 +70,8 @@ describe Polls::Questions::AnswersComponent do
render_inline Polls::Questions::AnswersComponent.new(question)
expect(page).to have_selector "span.disabled", text: "Yes"
expect(page).to have_selector "span.disabled", text: "No"
expect(page).to have_css "span.disabled", text: "Yes"
expect(page).to have_css "span.disabled", text: "No"
end
it "user cannot vote when poll expired it renders disabled answers" do
@@ -80,8 +80,8 @@ describe Polls::Questions::AnswersComponent do
render_inline Polls::Questions::AnswersComponent.new(question)
expect(page).to have_selector "span.disabled", text: "Yes"
expect(page).to have_selector "span.disabled", text: "No"
expect(page).to have_css "span.disabled", text: "Yes"
expect(page).to have_css "span.disabled", text: "No"
end
describe "geozone" do
@@ -95,8 +95,8 @@ describe Polls::Questions::AnswersComponent do
render_inline Polls::Questions::AnswersComponent.new(question)
expect(page).to have_selector "span.disabled", text: "Yes"
expect(page).to have_selector "span.disabled", text: "No"
expect(page).to have_css "span.disabled", text: "Yes"
expect(page).to have_css "span.disabled", text: "No"
end
it "reading a same-geozone poll it renders buttons to vote question answers" do