From 0c2e752932374dcdbe8effd02a1d9f3e7d7e4f65 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Javi=20Mart=C3=ADn?= Date: Thu, 20 May 2021 00:00:09 +0200 Subject: [PATCH] Simplify overriding menu dropdown icon color By default Foundation uses a `#1779ba transparent transparent` transparent border. We were overriding the whole border, when we only needed to override the top border. Furthermore, we were overriding it twice: once in the public area and once in the admin area. However, if we use `currentcolor`, we only have to override it once, and in both cases the border will have the same color as the text surrounding it (white in the public area and black in the admin area). --- app/assets/stylesheets/admin.scss | 4 ---- app/assets/stylesheets/layout.scss | 2 +- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/app/assets/stylesheets/admin.scss b/app/assets/stylesheets/admin.scss index d2d2915f4..c05286a01 100644 --- a/app/assets/stylesheets/admin.scss +++ b/app/assets/stylesheets/admin.scss @@ -155,10 +155,6 @@ $table-header: #ecf1f6; color: $admin-color; } - .dropdown.menu > .is-dropdown-submenu-parent > a::after { - border-color: #000 transparent transparent; - } - .fieldset { select { diff --git a/app/assets/stylesheets/layout.scss b/app/assets/stylesheets/layout.scss index 9d459878b..5f4bae0d5 100644 --- a/app/assets/stylesheets/layout.scss +++ b/app/assets/stylesheets/layout.scss @@ -644,7 +644,7 @@ body > header, } &.is-dropdown-submenu-parent > a::after { - border-color: #fff transparent transparent; + border-top-color: currentcolor; } }