consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Remove method to get votes for budget investments

Browse Source 
After commit 0214184b2, this method was only used in two places and was
only useful in one of them. IMHO it isn't worth it add a monkey-patch
for such a minor usage.
This commit is contained in:
Javi Martín
2022-04-05 22:44:30 +02:00
parent c25ab8e4a6
commit 0a3c86b92e
2 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/models/user.rb
View File

@@ -153,7 +153,7 @@ class User < ApplicationRecord
end end
def voted_in_group?(group) def voted_in_group?(group)
votes.for_budget_investments(Budget::Investment.where(group: group)).exists? votes.where(votable: Budget::Investment.where(group: group)).exists?
end end
def headings_voted_within_group(group) def headings_voted_within_group(group)
@@ -161,7 +161,7 @@ class User < ApplicationRecord
end end
def voted_investments def voted_investments
Budget::Investment.where(id: votes.for_budget_investments.pluck(:votable_id)) Budget::Investment.where(id: votes.where(votable: Budget::Investment.all).pluck(:votable_id))
end end
def administrator? def administrator?

4
config/initializers/vote_extensions.rb
View File

@@ -13,10 +13,6 @@ ActsAsVotable::Vote.class_eval do
Comment.public_for_api.pluck(:id)) Comment.public_for_api.pluck(:id))
end end
def self.for_budget_investments(budget_investments = Budget::Investment.all)
where(votable_type: "Budget::Investment", votable_id: budget_investments)
end
def value def value
vote_flag vote_flag
end end