consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Simplify display rules for show-children icon

Browse Source 
We were using `display: inline` assuming that's the way elements will be
displayed by default when shown. However, those elements could be
displayed in a different way (inline-flex, for instance). So we avoid
any possible conflicts by using the `display: none` rule when we want to
hide the elements.

Besides, the code is now symmetrical and IMHO easier to follow.
This commit is contained in:
Javi Martín
2020-09-11 01:11:59 +02:00
parent 74e819e4e7
commit 0824b64d4b
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
app/assets/stylesheets/layout.scss
View File

@@ -2114,7 +2114,6 @@ table {
.responses-count { .responses-count {
.show-children { .show-children {
@include has-fa-icon(plus-square, regular); @include has-fa-icon(plus-square, regular);
display: none;
} }
.collapse-children { .collapse-children {
@@ -2132,9 +2131,12 @@ table {
.collapse-children { .collapse-children {
display: none; display: none;
} }
}
&:not(.collapsed) {
.show-children { .show-children {
display: inline; display: none;
} }
} }
} }