From 074ae995f4b2063ea9028a6a5f5f1493c6fbda1b Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Juanjo=20Baz=C3=A1n?= <jjbazan@gmail.com>
Date: Mon, 14 Sep 2015 13:37:16 +0200
Subject: [PATCH] moves magic number to Settings

---
 app/models/proposal.rb         | 2 +-
 config/locales/settings.en.yml | 3 ++-
 config/locales/settings.es.yml | 3 ++-
 db/dev_seeds.rb                | 1 +
 db/seeds.rb                    | 3 +++
 5 files changed, 9 insertions(+), 3 deletions(-)

diff --git a/app/models/proposal.rb b/app/models/proposal.rb
index 913b23fcc..81b861608 100644
--- a/app/models/proposal.rb
+++ b/app/models/proposal.rb
@@ -101,7 +101,7 @@ class Proposal < ActiveRecord::Base
   end
 
   def self.votes_needed_for_success
-    53726
+    Setting.value_for('votes_for_proposal_success').to_i
   end
 
   protected
diff --git a/config/locales/settings.en.yml b/config/locales/settings.en.yml
index 6ef8d4053..8cc261c1e 100644
--- a/config/locales/settings.en.yml
+++ b/config/locales/settings.en.yml
@@ -7,4 +7,5 @@ en:
     official_level_5_name: "Level 5 official positions"
     max_ratio_anon_votes_on_debates: "Max allowed percentage of anonymous votes per Debate"
     max_votes_for_proposal_edit: "Number of votes where a Proposal is not editable anymore"
-    proposal_code_prefix: "Prefix for Proposals codes"
\ No newline at end of file
+    proposal_code_prefix: "Prefix for Proposals codes"
+    votes_for_proposal_success: "Number of votes needed for Proposal approval"
\ No newline at end of file
diff --git a/config/locales/settings.es.yml b/config/locales/settings.es.yml
index 96e485069..fa80fbdad 100644
--- a/config/locales/settings.es.yml
+++ b/config/locales/settings.es.yml
@@ -7,4 +7,5 @@ es:
     official_level_5_name: "Cargos públicos de nivel 5"
     max_ratio_anon_votes_on_debates: "Porcentaje máximo de votos anónimos por Debate"
     max_votes_for_proposal_edit: "Número de votos en que una Propuesta deja de poderse editar"
-    proposal_code_prefix: "Prefijo para los códigos de Propuestas"
\ No newline at end of file
+    proposal_code_prefix: "Prefijo para los códigos de Propuestas"
+    votes_for_proposal_success: "Número de votos necesarios para aprobar una Propuesta"
\ No newline at end of file
diff --git a/db/dev_seeds.rb b/db/dev_seeds.rb
index d8062e44f..f979d9453 100644
--- a/db/dev_seeds.rb
+++ b/db/dev_seeds.rb
@@ -11,6 +11,7 @@ Setting.create(key: 'official_level_5_name', value: 'Alcaldesa')
 Setting.create(key: 'max_ratio_anon_votes_on_debates', value: '50')
 Setting.create(key: 'max_votes_for_proposal_edit', value: '1000')
 Setting.create(key: 'proposal_code_prefix', value: 'MAD')
+Setting.create(key: 'votes_for_proposal_success', value: '100')
 
 puts "Creating Users"
 
diff --git a/db/seeds.rb b/db/seeds.rb
index 181386c4c..27da98e1c 100644
--- a/db/seeds.rb
+++ b/db/seeds.rb
@@ -20,3 +20,6 @@ Setting.create(key: 'max_votes_for_proposal_edit', value: '1000')
 
 # Prefix for the Proposal codes
 Setting.create(key: 'proposal_code_prefix', value: 'MAD')
+
+# Number of votes needed for proposal success
+Setting.create(key: 'votes_for_proposal_success', value: '53726')