consul/grecia
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Add trait to create an investment with a valuator

Browse Source
This commit is contained in:
Javi Martín
2019-09-21 17:06:08 +02:00
parent a9159e0ec8
commit 05f63ca08d
3 changed files with 16 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
spec/factories/budgets.rb
View File

@@ -173,6 +173,10 @@ FactoryBot.define do
administrator
end
trait :with_valuator do
valuators { [create(:valuator)] }
end
trait :flagged do
after :create do |investment|
Flag.flag(create(:user), investment)

11
spec/features/admin/budget_investments_spec.rb
View File

@@ -447,8 +447,7 @@ describe "Admin budget investments" do
scenario "Filtering by assignment status" do
create(:budget_investment, :with_administrator, title: "Assigned idea", budget: budget)
create(:budget_investment, title: "Evaluating...", budget: budget,
valuators: [create(:valuator)])
create(:budget_investment, :with_valuator, title: "Evaluating...", budget: budget)
create(:budget_investment, title: "With group", budget: budget,
valuator_groups: [create(:valuator_group)])
@@ -1652,10 +1651,10 @@ describe "Admin budget investments" do
end
scenario "Showing the valuating checkbox" do
investment1 = create(:budget_investment, :with_administrator, :visible_to_valuators,
budget: budget, valuators: [create(:valuator)])
investment2 = create(:budget_investment, :with_administrator, :invisible_to_valuators,
budget: budget, valuators: [create(:valuator), create(:valuator)])
investment1 = create(:budget_investment, :with_administrator, :with_valuator, :visible_to_valuators,
budget: budget)
investment2 = create(:budget_investment, :with_administrator, :with_valuator, :invisible_to_valuators,
budget: budget)
visit admin_budget_budget_investments_path(budget)

14
spec/models/budget/investment_spec.rb
View File

@@ -416,7 +416,7 @@ describe Budget::Investment do
describe "managed" do
it "returns all open investments with assigned admin but without assigned valuators" do
investment1 = create(:budget_investment, :with_administrator, valuators: [create(:valuator)])
investment1 = create(:budget_investment, :with_administrator, :with_valuator)
investment2 = create(:budget_investment, :with_administrator, :finished)
investment3 = create(:budget_investment, :with_administrator)
@@ -429,8 +429,8 @@ describe Budget::Investment do
describe "valuating" do
it "returns all investments with assigned valuator but valuation not finished" do
investment1 = create(:budget_investment)
investment2 = create(:budget_investment, valuators: [create(:valuator)])
investment3 = create(:budget_investment, :finished, valuators: [create(:valuator)])
investment2 = create(:budget_investment, :with_valuator)
investment3 = create(:budget_investment, :with_valuator, :finished)
valuating = Budget::Investment.valuating
@@ -454,8 +454,8 @@ describe Budget::Investment do
describe "valuation_finished" do
it "returns all investments with valuation finished" do
investment1 = create(:budget_investment)
investment2 = create(:budget_investment, valuators: [create(:valuator)])
investment3 = create(:budget_investment, :finished, valuators: [create(:valuator)])
investment2 = create(:budget_investment, :with_valuator)
investment3 = create(:budget_investment, :with_valuator, :finished)
valuation_finished = Budget::Investment.valuation_finished
@@ -1155,8 +1155,8 @@ describe Budget::Investment do
describe "with under_valuation filter" do
let(:params) { { advanced_filters: ["under_valuation"], budget_id: budget.id } }
it "returns only investment under valuation" do
investment1 = create(:budget_investment, :with_administrator, :unfinished,
budget: budget, valuators: [create(:valuator)])
investment1 = create(:budget_investment, :with_administrator, :unfinished, :with_valuator,
budget: budget)
create(:budget_investment, :with_administrator, budget: budget)
create(:budget_investment, budget: budget)