diff --git a/.rubocop.yml b/.rubocop.yml index 27e3b1624..76c96001d 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -553,6 +553,9 @@ RSpec/OverwritingSetup: RSpec/Rails/HaveHttpStatus: Enabled: true +RSpec/Rails/InferredSpecType: + Enabled: true + RSpec/RepeatedExample: Enabled: true diff --git a/spec/helpers/budget_investments_helper_spec.rb b/spec/helpers/budget_investments_helper_spec.rb index 3b97dbb1b..5d88d1ae6 100644 --- a/spec/helpers/budget_investments_helper_spec.rb +++ b/spec/helpers/budget_investments_helper_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe BudgetInvestmentsHelper, type: :helper do +RSpec.describe BudgetInvestmentsHelper do describe "#set_direction" do it "returns ASC if current_direction is DESC" do expect(set_direction("desc")).to eq "asc" diff --git a/spec/helpers/comments_helper_spec.rb b/spec/helpers/comments_helper_spec.rb index 07098c6a8..f1d85a2b4 100644 --- a/spec/helpers/comments_helper_spec.rb +++ b/spec/helpers/comments_helper_spec.rb @@ -10,7 +10,7 @@ require "rails_helper" # end # end # end -RSpec.describe CommentsHelper, type: :helper do +RSpec.describe CommentsHelper do describe "#user_level_class" do def comment_double(as_administrator: false, as_moderator: false, official: false) user = instance_double("User", official?: official, official_level: "Y") diff --git a/spec/helpers/settings_helper_spec.rb b/spec/helpers/settings_helper_spec.rb index a28b5bd03..f07a97f10 100644 --- a/spec/helpers/settings_helper_spec.rb +++ b/spec/helpers/settings_helper_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe SettingsHelper, type: :helper do +RSpec.describe SettingsHelper do describe "#setting" do it "returns a hash with all settings values" do Setting["key1"] = "value1" diff --git a/spec/models/community_spec.rb b/spec/models/community_spec.rb index 072e0cb36..a95964dfb 100644 --- a/spec/models/community_spec.rb +++ b/spec/models/community_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe Community, type: :model do +RSpec.describe Community do it "is valid when create proposal" do proposal = create(:proposal) diff --git a/spec/models/i18n_content_spec.rb b/spec/models/i18n_content_spec.rb index 7021a75ce..6fe557ae6 100644 --- a/spec/models/i18n_content_spec.rb +++ b/spec/models/i18n_content_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe I18nContent, type: :model do +RSpec.describe I18nContent do let(:i18n_content) { build(:i18n_content, key: "awe.so.me") } it "is valid" do diff --git a/spec/models/identity_spec.rb b/spec/models/identity_spec.rb index eb5b8cd2e..9ed573b36 100644 --- a/spec/models/identity_spec.rb +++ b/spec/models/identity_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe Identity, type: :model do +RSpec.describe Identity do let(:identity) { build(:identity) } it "is valid" do diff --git a/spec/models/legislation/annotation_spec.rb b/spec/models/legislation/annotation_spec.rb index a3e239521..c162e2fb6 100644 --- a/spec/models/legislation/annotation_spec.rb +++ b/spec/models/legislation/annotation_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe Legislation::Annotation, type: :model do +RSpec.describe Legislation::Annotation do let(:draft_version) { create(:legislation_draft_version) } let(:annotation) { create(:legislation_annotation, draft_version: draft_version) } diff --git a/spec/models/legislation/answer_spec.rb b/spec/models/legislation/answer_spec.rb index ae44fbc01..faec3c406 100644 --- a/spec/models/legislation/answer_spec.rb +++ b/spec/models/legislation/answer_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe Legislation::Answer, type: :model do +RSpec.describe Legislation::Answer do let(:legislation_answer) { build(:legislation_answer) } it "is valid" do diff --git a/spec/models/legislation/process/phase_spec.rb b/spec/models/legislation/process/phase_spec.rb index c51f0a998..11fd7e1a7 100644 --- a/spec/models/legislation/process/phase_spec.rb +++ b/spec/models/legislation/process/phase_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe Legislation::Process::Phase, type: :model do +RSpec.describe Legislation::Process::Phase do let(:process) { create(:legislation_process) } let(:process_in_draft_phase) { create(:legislation_process, :in_draft_phase) } diff --git a/spec/models/legislation/process/publication_spec.rb b/spec/models/legislation/process/publication_spec.rb index 3a347b962..b0c6ae0e5 100644 --- a/spec/models/legislation/process/publication_spec.rb +++ b/spec/models/legislation/process/publication_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe Legislation::Process::Publication, type: :model do +RSpec.describe Legislation::Process::Publication do let(:process) { create(:legislation_process) } describe "#enabled?" do diff --git a/spec/models/poll/question_spec.rb b/spec/models/poll/question_spec.rb index de7155f5d..f5bd37735 100644 --- a/spec/models/poll/question_spec.rb +++ b/spec/models/poll/question_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe Poll::Question, type: :model do +RSpec.describe Poll::Question do let(:poll_question) { build(:poll_question) } describe "Concerns" do diff --git a/spec/models/site_customization/content_block_spec.rb b/spec/models/site_customization/content_block_spec.rb index e5f1e1ec5..056a273ee 100644 --- a/spec/models/site_customization/content_block_spec.rb +++ b/spec/models/site_customization/content_block_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe SiteCustomization::ContentBlock, type: :model do +RSpec.describe SiteCustomization::ContentBlock do let(:block) { build(:site_customization_content_block) } it "is valid" do diff --git a/spec/models/site_customization/page_spec.rb b/spec/models/site_customization/page_spec.rb index cc700a59f..8ab77b4d3 100644 --- a/spec/models/site_customization/page_spec.rb +++ b/spec/models/site_customization/page_spec.rb @@ -1,6 +1,6 @@ require "rails_helper" -RSpec.describe SiteCustomization::Page, type: :model do +RSpec.describe SiteCustomization::Page do let(:custom_page) { build(:site_customization_page) } it_behaves_like "globalizable", :site_customization_page